How to post a patch??

[x b]

I guess what I really want to know is what the suggested method for posting an addition to ShowEQ would be? Basically a rundown of the most efficient and easy method for the major ShowEQ devs (Zaphod specifically) would like submissions. I dont have one yet, as I have been waiting on the LDoN (spawn packet changes and god know what might make live) to change before I start to tackle a piece I have long missed (Exp Window).

I basically want to make sure nobody has to do any extra work...and I havent seen this posted before.

x_b

Oh..and if its been posted before, I only need 1 person to tell me to research... :D

[PriestOfDiscord]

This has been answered many times, but here is one answer:

http://seq.sourceforge.net/forums/showthread.php?s=&threadid=466&highlight=submitting+patch

[Zaphod]

Generally patches are very much appreciated. But there are things that can annoy me.

My biggest pet peeve :( about patches is when they are in the dreaded context diff format (diff -c) or any format other then unified diff format (diff -u). This is because I manually read through each patch before applying them and I find the unified format much more human readable. Also, I sometimes end up having to manually copy and paste sections out of the patch when I've been editing the same file (sometimes patch can get confused, which can be really bad juju). So, please, please, please use the unified diff format (diff -u) :).

Another peeve is hacky patches with large sections of existing code just commented out.

Here are some basic instructions:
[list=1]
Make your changes
Then do a diff against the latest code. If pserver CVS is current:

$ cd <showeq_dir>
$ cvs diff -u > /tmp/my_great.patch


If there is a tarball that is more current then pserver CVS (basically if a CVS commit has been done in the last day) then try something akin to the following:

$ cd <showeq_dir>/..
$ mkdir tarball
$ cd tarball
* Use your favorite browser to download the tarball into the tarball directory *
$ tar xjvf ShowEQ-4.3.11.tar.bz2 # or whatever the current tarballs name is
$ cd <showeq_dir>
$ make maintainer-clean # This wipes most extraneous files
$ diff -ur <showeq_dir>/../tarball/showeq . >/tmp/my_great.patch

Then submit your changes (I'll borrow from a Mr. Suspicious post):

Originally posted by Mr. Suspicious (http://seq.sourceforge.net/forums/showthread.php?s=&threadid=3843)
1: Goto Patch section

http://www.12test.com/seq/images/patch1.jpg

2: Login to the patch section (this is DIFFERENT then the forum login account you already use), if you didn't have setup a user account with sourceforge yet, then do so first. Remember to select "remember me" to make the cookie as persistent as possible.

http://www.12test.com/seq/images/patch2.jpg

3: After you've logged into the patch section you _might_ have to get back to the main page to be able to find the patch section you were at again. After you get back there you see a new link: submit patch.

http://www.12test.com/seq/images/patch3.jpg

4: Click that link, rest is pretty self explanatory (spelling?)
[/list=1]

In general most patches will get in. It is just a matter of how cranky I will be after reviewing and applying them.

Enjoy,
Zaphod (dohpaZ)