perlmonkey
02-16-2004, 04:30 PM
I'm totally re-writing my bazaar code for 5.x. The following is how I'm doing it and I just want to pass it in front of other folks in case I'm being stupid:
1. A new sub-class of PacketStreamLog called BazaarPacketLog will handle the heavy lifting
2. A new menu option will be listed with the other logging options for bazaar data.
3. When that option is turned on, a full packet stream log for all OP_BazaarSearch packets will be saved along with decoded item prices and merchant name mappings.
This required changes to the XML prefs, interface.{cpp,h}, packet.cpp and packetlog.{cpp,h}
Does anyone more experienced with the code than I see a pitfall here? This is all untested so far, but it looks right, and I'll be testing it out tonight.
This should satisfy the desire to have an option to control bazaar logging as well as using a more standard format (I was outputting an EQ client eqlog_*.txt format record for each item before).
Unless something major changes, I won't be back-porting this change to 4.x. There's just too much that changed and the back-port would be painful. Sorry 4.x guys... :-/
1. A new sub-class of PacketStreamLog called BazaarPacketLog will handle the heavy lifting
2. A new menu option will be listed with the other logging options for bazaar data.
3. When that option is turned on, a full packet stream log for all OP_BazaarSearch packets will be saved along with decoded item prices and merchant name mappings.
This required changes to the XML prefs, interface.{cpp,h}, packet.cpp and packetlog.{cpp,h}
Does anyone more experienced with the code than I see a pitfall here? This is all untested so far, but it looks right, and I'll be testing it out tonight.
This should satisfy the desire to have an option to control bazaar logging as well as using a more standard format (I was outputting an EQ client eqlog_*.txt format record for each item before).
Unless something major changes, I won't be back-porting this change to 4.x. There's just too much that changed and the back-port would be painful. Sorry 4.x guys... :-/