PDA

View Full Version : 1/15 patch



Newby
01-15-2020, 06:28 PM
structs and opcodes...

Loki
01-15-2020, 06:55 PM
Works fine here.. thanks!

cn187
01-16-2020, 10:25 AM
My internet was down for a good chunk of yesterday, but I should have some additional opcodes to contribute later today.

Loki
01-16-2020, 04:20 PM
Let me know when beta 6 is updated. :)

cn187
01-16-2020, 05:51 PM
Here are a few additional opcodes. I haven't had a chance to fully test them, but they should be correct (most aren't necessary for SEQ anyway, but are helpful to eliminate noise in the logs).

This patch applies *after* newby's.

I've also committed both patches to the beta 6 branch.

Loki
01-16-2020, 06:02 PM
Seems it's for pre 6 beta?

~/src/showeq-5.13.10.9$ patch -p0 < ../../diff-200115-2.txt
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/branches/pre_6_0_beta/conf/zoneopcodes.xml b/branches/pre_6_0_beta/conf/zoneopcodes.xml
|index 267bab1..842fee6 100644
|--- a/branches/pre_6_0_beta/conf/zoneopcodes.xml
|+++ b/branches/pre_6_0_beta/conf/zoneopcodes.xml
--------------------------

cn187
01-16-2020, 06:25 PM
Yeah, sorry, I tend to generate my patches with git. Try -p3

Loki
01-16-2020, 06:58 PM
Ugh I wiped out my comment after pasting the error. Thanks. Got beta 6 installed anyway :)

cn187
01-16-2020, 07:08 PM
Actually. it looks like it's there (assuming the comment you're talking about is that it's generated for beta 6), I just completely read past it.

Yes, I generated the diff off the beta branch, but zoneopcodes.xml is the same (for now at least) across both versions, so the patch will still apply to either, as long as you're applying the patch from the correct directory with the correct -p value (and assuming no local changes).

I think for previous patches, I created the patch so it would apply the same way as newby's (with -p0), but this time I forgot, so it's -p3.

BlueAdept
01-17-2020, 08:47 AM
SVN and Tarball updated. Thank you.

Loki
01-17-2020, 12:47 PM
Think I was trying to remove my username from the paste and ended up doing more damage. Thank you, Newby, BlueAdept and others for all the hard work.