PDA

View Full Version : small patch



Newby
02-18-2020, 03:49 PM
I upgraded my system today and it installed a new version of the libstdc++ library. Showeq started seg faulting whenever I zoned into a zone that I had zone filters set up for.

I tracked it down and fixed it, but I'm not really a C++ dev. I'd appreciate other eyes checking off on it.


Index: src/filter.cpp
================================================== =================
--- src/filter.cpp (revision 1014)
+++ src/filter.cpp (working copy)
@@ -444,13 +444,11 @@
{
// get the Filter object
filter = it->second;
-
- // erase the member from the list
- m_filters.erase(it);

// delete the filter
delete filter;
}
+ m_filters.clear ();

return true;
}

cn187
02-18-2020, 07:45 PM
Looks good to me. That's pretty much identical to the fix I made to the v6 beta branch in r979. I probably should have backported the fix to trunk, but I didn't really think about it. Sorry.